Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SchemaFunc #1285

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Support SchemaFunc #1285

merged 5 commits into from
Jul 11, 2023

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jul 11, 2023 •
edited
Loading

Adds support for SchemaFunc as introduced in hashicorp/terraform-plugin-sdk#1218.

Note: This will require all providers who upgrade to include this version of the bridge to be using >=v2.27.0 of Pulumi's terraform-plugin-sdk.

Rebased on top of #1287.

@iwahbe iwahbe self-assigned this Jul 11, 2023
@github-actions
Copy link

Diff for pulumi-random with merge commit 43933f0

@github-actions
Copy link

Diff for pulumi-random with merge commit 4d96bc9

@iwahbe iwahbe force-pushed the iwahbe/1284/support-SchemaFunc branch from 8f8a4e3 to 4142ae7 Compare July 11, 2023 09:56
@github-actions
Copy link

Diff for pulumi-random with merge commit 0454974

@mikhailshilkov
Copy link
Member

Note: This will require all providers who upgrade to include this version of the bridge to be using >=v2.27.0 of Pulumi's terraform-plugin-sdk.

How disruptive is it going to be? Will we need to do this manually in every provider?

@iwahbe
Copy link
Member Author

iwahbe commented Jul 11, 2023

Note: This will require all providers who upgrade to include this version of the bridge to be using >=v2.27.0 of Pulumi's terraform-plugin-sdk.

How disruptive is it going to be? Will we need to do this manually in every provider?

It will be minimally disruptive. New versions are reliably backwards compatible and upgrade-provider handles this for us. I don't expect manual intervention will be necessary.

@iwahbe iwahbe mentioned this pull request Jul 11, 2023
Merged
@iwahbe iwahbe force-pushed the iwahbe/1284/support-SchemaFunc branch from 4142ae7 to 41cf055 Compare July 11, 2023 12:31
@github-actions
Copy link

Diff for pulumi-random with merge commit 7ef0b89

@github-actions
Copy link

Diff for pulumi-random with merge commit c09d81f

@iwahbe iwahbe force-pushed the iwahbe/1284/support-SchemaFunc branch from a566e25 to 47c31f3 Compare July 11, 2023 13:54
@iwahbe iwahbe enabled auto-merge (squash) July 11, 2023 13:55
@github-actions
Copy link

Diff for pulumi-random with merge commit 04205a3

@github-actions
Copy link

Diff for pulumi-random with merge commit 1ecb864

@iwahbe iwahbe merged commit 63d82af into master Jul 11, 2023
@iwahbe iwahbe deleted the iwahbe/1284/support-SchemaFunc branch July 11, 2023 14:11
@iwahbe iwahbe mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

@danielrbradley danielrbradley Awaiting requested review from danielrbradley

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwahbe @mikhailshilkov @thomas11